Merged
Conversation
3fbd142 to
9efcf8b
Compare
roshan-gorasia-cko
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add card scheme selection support to Dynamic Checkout and fix inverted restriction
logic for IIN/scheme allowlists.
Changes
Scheme selection support (
card.ts)enableCardSchemeSelectionandpreferredSchemesoptions to the card formfrom the payment method config
handles scheme UI when enabled)
scheme_selection_enabledandscheme_selection_default_orderto theCardtype
Fix card restriction logic (
card.ts)validateCardRestrictions:restrict_to_schemesis an allowlist, but theprevious logic treated matches as blocked — inverted the condition so cards are
restricted only when their scheme is not in the list
handleIinRestrictionFromMessage: same inversion fix forrestrict_to_iins—cards are now restricted only when the IIN is not in the allowlist
Impact
restrict_to_schemes/restrict_to_iinswerepreviously incorrectly blocked. This fix unblocks valid cards and correctly blocks
cards outside the allowlist.
instead of a static logo.
Testing Plan
scheme_selection_enabled: true)selector appears
restrict_to_schemes: ["mastercard"], enter a Mastercard-eligible card,and verify it is allowed
restricted
restrict_to_iinswith a specific IIN, enter a card matching that IIN,and verify it is allowed
Additional Context
The restriction logic used variable names like
isBlockedScheme/blockedSchemewhich led to treating the allowlist as a blocklist. The fix renames and simplifies
the logic to make intent clear (
hasAllowedScheme,isAllowedIin).